New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numbers in subcommand names #4164

Merged
merged 2 commits into from Jul 6, 2017

Conversation

3 participants
@chetansatasiya
Contributor

chetansatasiya commented Jun 20, 2017

Fixes #4159

@chetansatasiya

This comment has been minimized.

Show comment
Hide comment
@chetansatasiya

chetansatasiya Jun 20, 2017

Contributor

I have added my PR to allow the numbers into the subcommand Sanitizing.

@danielbachhuber & @schlessera Please let me know if any changes in my PR

Contributor

chetansatasiya commented Jun 20, 2017

I have added my PR to allow the numbers into the subcommand Sanitizing.

@danielbachhuber & @schlessera Please let me know if any changes in my PR

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jun 20, 2017

Member

@chetansatasiya Please add a test case to check for actually adding such a subcommand.

Member

schlessera commented Jun 20, 2017

@chetansatasiya Please add a test case to check for actually adding such a subcommand.

@schlessera schlessera added this to the 1.3.0 milestone Jun 20, 2017

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jun 25, 2017

Member

@chetansatasiya In case you don't know how to proceed with the tests, here's a brief overview: https://make.wordpress.org/cli/handbook/pull-requests/#running-and-writing-tests .

Let me know if you need any additional guidance!

Member

schlessera commented Jun 25, 2017

@chetansatasiya In case you don't know how to proceed with the tests, here's a brief overview: https://make.wordpress.org/cli/handbook/pull-requests/#running-and-writing-tests .

Let me know if you need any additional guidance!

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Jul 4, 2017

Member

I've added a test in 38285ac

Member

danielbachhuber commented Jul 4, 2017

I've added a test in 38285ac

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jul 5, 2017

Member

Test seemed to have randomly failed for PHP 5.6, restarted...

Member

schlessera commented Jul 5, 2017

Test seemed to have randomly failed for PHP 5.6, restarted...

@danielbachhuber danielbachhuber merged commit 853c9a5 into wp-cli:master Jul 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chetansatasiya chetansatasiya deleted the chetansatasiya:Fix-4159 branch Jul 11, 2017

@danielbachhuber danielbachhuber changed the title from Allowed numbers to subcommand Sanitizing to Allow numbers in subcommand names Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment