New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH URL parser regexp changes to allow for null port number #4182

Merged
merged 1 commit into from Jul 3, 2017

Conversation

4 participants
@freegenie
Contributor

freegenie commented Jun 24, 2017

Related to #4180, changes the SSH parser regexp to allow port number to be missing.

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Jun 24, 2017

Contributor

Thanks, could you do a phpunit test please? (See https://github.com/wp-cli/wp-cli/blob/master/tests/test-utils.php#L58).

Contributor

gitlost commented Jun 24, 2017

Thanks, could you do a phpunit test please? (See https://github.com/wp-cli/wp-cli/blob/master/tests/test-utils.php#L58).

@freegenie

This comment has been minimized.

Show comment
Hide comment
@freegenie

freegenie Jun 25, 2017

Contributor
Contributor

freegenie commented Jun 25, 2017

@danielbachhuber danielbachhuber added the bug label Jun 28, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Jun 30, 2017

Member

@freegenie Still planning to add tests here?

Member

danielbachhuber commented Jun 30, 2017

@freegenie Still planning to add tests here?

@freegenie

This comment has been minimized.

Show comment
Hide comment
@freegenie

freegenie Jul 2, 2017

Contributor

Done and rebased on latest master.

Contributor

freegenie commented Jul 2, 2017

Done and rebased on latest master.

@danielbachhuber danielbachhuber added this to the 1.3.0 milestone Jul 3, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber
Member

danielbachhuber commented Jul 3, 2017

Thanks @freegenie !

@danielbachhuber danielbachhuber merged commit 027bdcf into wp-cli:master Jul 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment