New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WP_CLI\Utils\get_home_dir() helper method #4184

Merged
merged 4 commits into from Jun 26, 2017

Conversation

4 participants
@Ippey
Contributor

Ippey commented Jun 25, 2017

Related #4091.
Add get_home_dir() function into Utils.

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Jun 25, 2017

Contributor

Thanks @Ippey - could you have wp-cli use the new function - see WP_CLI::get_cache() (https://github.com/wp-cli/wp-cli/blob/master/php/class-wp-cli.php#L77) and also the 3 instances in WP_CLI\Runner?

Also to avoid test bleed it's nice if tests leave things as they find them so could you save/restore the environment in the test (see eg https://github.com/wp-cli/php-cli-tools/blob/master/tests/test-shell.php#L15). Also the test should also use the WP coding style. Ta!

Contributor

gitlost commented Jun 25, 2017

Thanks @Ippey - could you have wp-cli use the new function - see WP_CLI::get_cache() (https://github.com/wp-cli/wp-cli/blob/master/php/class-wp-cli.php#L77) and also the 3 instances in WP_CLI\Runner?

Also to avoid test bleed it's nice if tests leave things as they find them so could you save/restore the environment in the test (see eg https://github.com/wp-cli/php-cli-tools/blob/master/tests/test-shell.php#L15). Also the test should also use the WP coding style. Ta!

@Ippey

This comment has been minimized.

Show comment
Hide comment
@Ippey

Ippey Jun 25, 2017

Contributor

@gitlost Thank you for your checking! I'll try them tonight.

Contributor

Ippey commented Jun 25, 2017

@gitlost Thank you for your checking! I'll try them tonight.

@gitlost

Thanks @Ippey - looks good to me! (As a new reviewer I'm going to ask for a second opinion.)

@gitlost gitlost requested a review from schlessera Jun 26, 2017

@danielbachhuber danielbachhuber added this to the 1.3.0 milestone Jun 26, 2017

@danielbachhuber danielbachhuber merged commit ec3d1ff into wp-cli:master Jun 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Jun 26, 2017

Member

Looks good, thanks @Ippey !

Member

danielbachhuber commented Jun 26, 2017

Looks good, thanks @Ippey !

@gitlost gitlost removed the request for review from schlessera Jun 26, 2017

@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001

miya0001 Jun 27, 2017

Member

This PR was opened at contributor day in WordCamp Kyoto. 😄

Member

miya0001 commented Jun 27, 2017

This PR was opened at contributor day in WordCamp Kyoto. 😄

@danielbachhuber danielbachhuber changed the title from Add get home dir to Add WP_CLI\Utils\get_home_dir() helper method Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment