New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce included files (behat/phpunit in particular). Add 'cli' test build option. #4185

Merged
merged 8 commits into from Jul 31, 2017

Conversation

3 participants
@gitlost
Contributor

gitlost commented Jun 26, 2017

Issue #4170

Does not include behat or phpunit files.

Tries in general to only include files needed - for instance only specific symfony components, and no spdx-licenses, command, console or Pear stuff for composer.

Excludes "composer/ca-bundle/res/cacert.pem" as it doesn't seem to be needed as "rmccue/requests/library/Requests/Transport/cacert.pem" is used instead.

Processes the autoload_* files to remove unused entries.

Also adds a build option to make a much reduced test phar that can only run cli commands such as wp --version and wp cli check-update - although not used here it will be in a future patch to speed up testing (cli.feature in particular). (See gitlost#12 for the gory details.)

Also removes the "Include base project files, because the autoloader will load them" branch, added in #3923, that doesn't seem to be needed (I think).

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Jun 27, 2017

Member

Thanks @gitlost. It'd be nice to get #4108 running completely before we land this.

Member

danielbachhuber commented Jun 27, 2017

Thanks @gitlost. It'd be nice to get #4108 running completely before we land this.

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Jun 27, 2017

Contributor

Yes, are there ideas floating around as to how to do that?!

Contributor

gitlost commented Jun 27, 2017

Yes, are there ideas floating around as to how to do that?!

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Jun 28, 2017

Member

Yes, are there ideas floating around as to how to do that?!

@schlessera had it running, but I'm unsure of its current status.

Member

danielbachhuber commented Jun 28, 2017

Yes, are there ideas floating around as to how to do that?!

@schlessera had it running, but I'm unsure of its current status.

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jun 29, 2017

Member

I'll try to move #4108 forward, it is one of the tasks I wanted to be done for 1.3.0 as well.

Member

schlessera commented Jun 29, 2017

I'll try to move #4108 forward, it is one of the tasks I wanted to be done for 1.3.0 as well.

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Jul 31, 2017

Member

@gitlost Happy with this? If so, feel free to merge at your convenience.

I'd like to get this landed sooner rather than later so we can see if any bugs shake out of it.

Member

danielbachhuber commented Jul 31, 2017

@gitlost Happy with this? If so, feel free to merge at your convenience.

I'd like to get this landed sooner rather than later so we can see if any bugs shake out of it.

@gitlost gitlost merged commit 42bbe3e into master Jul 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gitlost gitlost deleted the issue_4170 branch Jul 31, 2017

@gitlost gitlost restored the issue_4170 branch Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment