New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail back to `tar xz` when `PharData` throws an Exception #4371

Merged
merged 3 commits into from Sep 21, 2017

Conversation

3 participants
@danielbachhuber
Member

danielbachhuber commented Sep 20, 2017

In certain systems, PharData fails on invalid archives that tar can
successfully handle.

See #4370

Fail back to `tar xz` when `PharData` throws an Exception
In certain systems, `PharData` fails on invalid archives that `tar` can
successfully handle.
@JPry

This comment has been minimized.

Show comment
Hide comment
@JPry

JPry Sep 21, 2017

Contributor

I tested this with my local VVV instance and the nightly phar, and it worked.

vagrant@vvv:/tmp$ mkdir test
vagrant@vvv:/tmp$ cd test/
vagrant@vvv:/tmp/test$ php ../wp-cli-nightly.phar core download
Downloading WordPress 4.8.2 (en_US)...
md5 hash verified: 2e8744a702a3d9527782d9135a4c9544
Warning: unable to decompress gzipped phar archive "/tmp/wp_59c2ff8e7af4a.tar.gz" to temporary file
Success: WordPress downloaded.

Slack message: https://wordpress.slack.com/archives/C02RP4T41/p1505951665000145?thread_ts=1505948297.000185&cid=C02RP4T41

Contributor

JPry commented Sep 21, 2017

I tested this with my local VVV instance and the nightly phar, and it worked.

vagrant@vvv:/tmp$ mkdir test
vagrant@vvv:/tmp$ cd test/
vagrant@vvv:/tmp/test$ php ../wp-cli-nightly.phar core download
Downloading WordPress 4.8.2 (en_US)...
md5 hash verified: 2e8744a702a3d9527782d9135a4c9544
Warning: unable to decompress gzipped phar archive "/tmp/wp_59c2ff8e7af4a.tar.gz" to temporary file
Success: WordPress downloaded.

Slack message: https://wordpress.slack.com/archives/C02RP4T41/p1505951665000145?thread_ts=1505948297.000185&cid=C02RP4T41

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Sep 21, 2017

Member

Updating the warning to:

Warning: PharData failed, falling back to 'tar gz' (unable to decompress gzipped phar archive "/tmp/wp_59c2ff8e7af4a.tar.gz" to temporary file)
Member

danielbachhuber commented Sep 21, 2017

Updating the warning to:

Warning: PharData failed, falling back to 'tar gz' (unable to decompress gzipped phar archive "/tmp/wp_59c2ff8e7af4a.tar.gz" to temporary file)
@miya0001

👍

@miya0001 miya0001 merged commit ee6aed3 into master Sep 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the fail-back branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment