New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide dictionary-based suggestions for common misspellings #4392

Merged
merged 1 commit into from Oct 5, 2017

Conversation

3 participants
@n8finch
Contributor

n8finch commented Oct 3, 2017

Hey folks!

This PR seeks to get the ball rolling on (or resolve) this issue: #4379

Per Alain's leading, I've added in the $suggestion_map array and the return check.

Several items in the array are used across different commands (e.g., wp post new and wp db new would both return the correct suggestion: Did you mean 'create'?

I've label this as a WIP, so happy to make edits or expand this.

Thanks!
Nate

@n8finch n8finch changed the title from [WIP] suggestion_mapadd array to php/utils.php to [WIP] add suggestion_map array to php/utils.php Oct 3, 2017

@danielbachhuber danielbachhuber added this to the 1.4.0 milestone Oct 4, 2017

@danielbachhuber

Thanks @n8finch ! Looks good on my end. I'll let @schlessera weigh in with his opinion/any requested changes.

@n8finch

This comment has been minimized.

Show comment
Hide comment
@n8finch

n8finch Oct 5, 2017

Contributor

Sounds good, and thanks!

Contributor

n8finch commented Oct 5, 2017

Sounds good, and thanks!

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Oct 5, 2017

Member

Looks good to me!

I'll merge the current collection, we can always add more later on.

Thanks for the work on this, @n8finch !

Member

schlessera commented Oct 5, 2017

Looks good to me!

I'll merge the current collection, we can always add more later on.

Thanks for the work on this, @n8finch !

@schlessera schlessera merged commit 7f4c4e4 into wp-cli:master Oct 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera changed the title from [WIP] add suggestion_map array to php/utils.php to Provide dictionary-based suggestions for common misspellings Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment