Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move phpunit PHP directive tests to behat. #4675

Merged
merged 1 commit into from Feb 8, 2018
Merged

Move phpunit PHP directive tests to behat. #4675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 17 additions & 0 deletions features/class-wp-cli.feature
View file
Open in desktop
@@ -0,0 +1,17 @@
Feature: Various utilities for WP-CLI commands

Scenario Outline: Check that `proc_open()` and `proc_close()` aren't disabled for `WP_CLI::launch()`
When I try `{INVOKE_WP_CLI_WITH_PHP_ARGS--ddisable_functions=<func>} --skip-wordpress eval 'WP_CLI::launch( null );'`
Then STDERR should contain:
"""
Error: Cannot do 'launch': The PHP functions `proc_open()` and/or `proc_close()` are disabled
"""
And STDOUT should be empty
And the return code should be 1

Examples:
| func |
| proc_open |
| proc_close |


52 changes: 52 additions & 0 deletions features/utils.feature
View file
Open in desktop
@@ -0,0 +1,52 @@
Feature: Utilities that do NOT depend on WordPress code

Scenario Outline: Check that `proc_open()` and `proc_close()` aren't disabled for `Utils\run_mysql_command()`
When I try `{INVOKE_WP_CLI_WITH_PHP_ARGS--ddisable_functions=<func>} --skip-wordpress eval 'WP_CLI\Utils\run_mysql_command( null, array() );'`
Then STDERR should contain:
"""
Error: Cannot do 'run_mysql_command': The PHP functions `proc_open()` and/or `proc_close()` are disabled
"""
And STDOUT should be empty
And the return code should be 1

Examples:
| func |
| proc_open |
| proc_close |

Scenario Outline: Check that `proc_open()` and `proc_close()` aren't disabled for `Utils\launch_editor_for_input()`
When I try `{INVOKE_WP_CLI_WITH_PHP_ARGS--ddisable_functions=<func>} --skip-wordpress eval 'WP_CLI\Utils\launch_editor_for_input( null, null );'`
Then STDERR should contain:
"""
Error: Cannot do 'launch_editor_for_input': The PHP functions `proc_open()` and/or `proc_close()` are disabled
"""
And STDOUT should be empty
And the return code should be 1

Examples:
| func |
| proc_open |
| proc_close |

# INI directive `sys_temp_dir` introduced PHP 5.5.0.
@require-php-5.5
Scenario: Check `Utils\get_temp_dir()` when `sys_temp_dir` directive set
# `sys_temp_dir` set to unwritable.
When I try `{INVOKE_WP_CLI_WITH_PHP_ARGS--dsys_temp_dir=\\tmp\\} --skip-wordpress eval 'echo WP_CLI\Utils\get_temp_dir();'`
Then STDERR should contain:
"""
Warning: Temp directory isn't writable
"""
And STDERR should contain:
"""
\tmp/
"""
And STDOUT should be:
"""
\tmp/
"""
And the return code should be 0

# `sys_temp_dir` unset.
When I run `{INVOKE_WP_CLI_WITH_PHP_ARGS--dsys_temp_dir=} --skip-wordpress eval 'echo WP_CLI\Utils\get_temp_dir();'`
Then STDOUT should match /\/$/
54 changes: 0 additions & 54 deletions tests/test-utils.php
View file
Open in desktop
Expand Up @@ -332,28 +332,6 @@ public function testNormalizeEols() {

public function testGetTempDir() {
$this->assertTrue( '/' === substr( Utils\get_temp_dir(), -1 ) );

// INI directive `sys_temp_dir` introduced PHP 5.5.0.
if ( version_compare( PHP_VERSION, '5.5.0', '>=' ) ) {

// `sys_temp_dir` set to unwritable.

$cmd = 'php ' . escapeshellarg( '-dsys_temp_dir=\\tmp\\' ) . ' php/boot-fs.php --skip-wordpress eval ' . escapeshellarg( 'echo WP_CLI\\Utils\\get_temp_dir();' ) . ' 2>&1';
$output = array();
exec( $cmd, $output );
$output = trim( implode( "\n", $output ) );
$this->assertTrue( false !== strpos( $output, 'Warning' ) );
$this->assertTrue( false !== strpos( $output, 'writable' ) );
$this->assertTrue( false !== strpos( $output, '\\tmp/' ) );

// `sys_temp_dir` unset.

$cmd = 'php ' . escapeshellarg( '-dsys_temp_dir=' ) . ' php/boot-fs.php --skip-wordpress eval ' . escapeshellarg( 'echo WP_CLI\\Utils\\get_temp_dir();' ) . ' 2>&1';
$output = array();
exec( $cmd, $output );
$output = trim( implode( "\n", $output ) );
$this->assertTrue( '/' === substr( $output, -1 ) );
}
}

public function testHttpRequestBadAddress() {
Expand Down Expand Up @@ -451,38 +429,6 @@ public function testHttpRequestBadCAcert() {
$class_wp_cli_logger->setValue( $prev_logger );
}

public function testRunMysqlCommandProcDisabled() {
$err_msg = 'Error: Cannot do \'run_mysql_command\': The PHP functions `proc_open()` and/or `proc_close()` are disabled';

$cmd = 'php -ddisable_functions=proc_open php/boot-fs.php --skip-wordpress eval ' . escapeshellarg( 'WP_CLI\\Utils\\run_mysql_command( null, array() );' ) . ' 2>&1';
$output = array();
exec( $cmd, $output );
$output = trim( implode( "\n", $output ) );
$this->assertTrue( false !== strpos( $output, $err_msg ) );

$cmd = 'php -ddisable_functions=proc_close php/boot-fs.php --skip-wordpress eval ' . escapeshellarg( 'WP_CLI\\Utils\\run_mysql_command( null, array() );' ) . ' 2>&1';
$output = array();
exec( $cmd, $output );
$output = trim( implode( "\n", $output ) );
$this->assertTrue( false !== strpos( $output, $err_msg ) );
}

public function testLaunchEditorForInputProcDisabled() {
$err_msg = 'Error: Cannot do \'launch_editor_for_input\': The PHP functions `proc_open()` and/or `proc_close()` are disabled';

$cmd = 'php -ddisable_functions=proc_open php/boot-fs.php --skip-wordpress eval ' . escapeshellarg( 'WP_CLI\\Utils\\launch_editor_for_input( null, null );' ) . ' 2>&1';
$output = array();
exec( $cmd, $output );
$output = trim( implode( "\n", $output ) );
$this->assertTrue( false !== strpos( $output, $err_msg ) );

$cmd = 'php -ddisable_functions=proc_close php/boot-fs.php --skip-wordpress eval ' . escapeshellarg( 'WP_CLI\\Utils\\launch_editor_for_input( null, null );' ) . ' 2>&1';
$output = array();
exec( $cmd, $output );
$output = trim( implode( "\n", $output ) );
$this->assertTrue( false !== strpos( $output, $err_msg ) );
}

/**
* @dataProvider dataPastTenseVerb
*/
Expand Down
16 changes: 0 additions & 16 deletions tests/test-wp-cli.php
View file
Open in desktop
Expand Up @@ -2,22 +2,6 @@

class WP_CLI_Test extends PHPUnit_Framework_TestCase {

public function testLaunchProcDisabled() {
$err_msg = 'Error: Cannot do \'launch\': The PHP functions `proc_open()` and/or `proc_close()` are disabled';

$cmd = 'php -ddisable_functions=proc_open php/boot-fs.php --skip-wordpress eval ' . escapeshellarg( 'WP_CLI::launch( null );' ) . ' 2>&1';
$output = array();
exec( $cmd, $output );
$output = trim( implode( "\n", $output ) );
$this->assertTrue( false !== strpos( $output, $err_msg ) );

$cmd = 'php -ddisable_functions=proc_close php/boot-fs.php --skip-wordpress eval ' . escapeshellarg( 'WP_CLI::launch( null );' ) . ' 2>&1';
$output = array();
exec( $cmd, $output );
$output = trim( implode( "\n", $output ) );
$this->assertTrue( false !== strpos( $output, $err_msg ) );
}

public function testGetPHPBinary() {
$this->assertSame( WP_CLI\Utils\get_php_binary(), WP_CLI::get_php_binary() );
}
Expand Down