Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support launching system editor with specific temp file extension #4691

Merged
merged 3 commits into from Feb 20, 2018

Conversation

2 participants
@danielbachhuber
Copy link
Member

danielbachhuber commented Feb 17, 2018

If the editor does some amount of syntax highlighting, it probably needs
the extension to enable the highlighting.

See wp-cli/config-command#48

Support launching system editor with specific temp file extension
If the editor does some amount of syntax highlighting, it probably needs
the extension to enable the highlighting.
* @return string|bool Edited text, if file is saved from editor; false, if no change to file.
*/
function launch_editor_for_input( $input, $filename = 'WP-CLI' ) {
function launch_editor_for_input( $input, $filename = 'WP-CLI', $ext = 'tmp' ) {

This comment has been minimized.

@schlessera

schlessera Feb 19, 2018

Member

$filename => $title

This comment has been minimized.

@danielbachhuber

danielbachhuber Feb 19, 2018

Author Member

Updated in 847de9a

@schlessera schlessera merged commit 4a1cb3f into master Feb 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the specific-ext branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.