New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty domain in framework test after get_sites_by_path change. #4695

Merged
merged 1 commit into from Feb 19, 2018

Conversation

2 participants
@gitlost
Contributor

gitlost commented Feb 19, 2018

Fixes #4694

Adjusts framework.feature:313 test to allow for this core changeset https://core.trac.wordpress.org/changeset/42698 which got around a bug in WP_Site_Query::query() which doesn't ignore domain__in when empty.

Does this by manually setting wp_blogs.domain to null so the query works across all WP versions.

@gitlost gitlost added this to the 2.0.0 milestone Feb 19, 2018

@gitlost gitlost requested a review from wp-cli/committers Feb 19, 2018

@danielbachhuber danielbachhuber merged commit 5262bb0 into master Feb 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the get_sites_by_path-trunk-change-framework-test branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment