New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show help text even when `proc_(open|close)` aren't available #4758

Merged
merged 1 commit into from Apr 3, 2018

Conversation

2 participants
@johnbillion
Contributor

johnbillion commented Apr 2, 2018

When running wp help on an environment where proc_open() or proc_close() aren't available, the command silently fails with no output (unless the --debug flag is used).

The command should output the help text using stdout in this situation, so the user still sees help text.

This change also improves the corresponding description of the --debug flag, and switches to returning -1 from Help_Command::pass_through_pager() so that its return value matches that of proc_close() when there's an error.

@schlessera schlessera added this to the 2.0.0 milestone Apr 3, 2018

@schlessera schlessera merged commit 66cbb25 into wp-cli:master Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera modified the milestones: 2.0.0, 1.5.1 Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment