New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lowest PHP version to test to 5.4 #4798

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@schlessera
Member

schlessera commented May 15, 2018

The build for testing WP-CLI is currently broken on PHP 5.3. Given that:

  • the current version v2.x is supposed to drop PHP 5.3 support;
  • PHP 5.3 only runs on Travis within a separate distro, which might not get the same care;
  • efforts in #4791 to fix the PHP 5.3 build have failed;
  • no bug reports were provided for the issue the tests on PHP 5.3 flag;

=> I've decided to just bump the minimum tested version to PHP 5.4 now.

Fixes #4791

Bump lowest PHP version to test to 5.4
The build for testing WP-CLI is currently broken on PHP 5.3. Given that:

- the current version v2.x is supposed to drop PHP 5.3 support;
- PHP 5.3 only runs on Travis within a separate distro, which might not get the same care;
- efforts in #4791 to fix the PHP 5.3 build have failed;
- no bug reports were provided for the issue the tests on PHP 5.3 flag;

=> I've decided to just bump the minimum tested version to PHP 5.4 now.

Fixes #4791

@schlessera schlessera added this to the 2.0.0 milestone May 15, 2018

@schlessera schlessera requested a review from wp-cli/committers May 15, 2018

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber May 15, 2018

Member

Build failure here too?

Member

danielbachhuber commented May 15, 2018

Build failure here too?

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera May 16, 2018

Member

Yes, which renders my theory of the problem being specific to the 5.3 Travis environment invalid.

Member

schlessera commented May 16, 2018

Yes, which renders my theory of the problem being specific to the 5.3 Travis environment invalid.

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera May 29, 2018

Member

Test failure was fixed via wp-cli/package-command#83

Closing this for now as it is not needed yet.

Member

schlessera commented May 29, 2018

Test failure was fixed via wp-cli/package-command#83

Closing this for now as it is not needed yet.

@schlessera schlessera closed this May 29, 2018

@schlessera schlessera deleted the skip-testing-on-php-53 branch May 29, 2018

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber May 29, 2018

Member

Test failure was fixed via wp-cli/package-command#83

Nice!

Member

danielbachhuber commented May 29, 2018

Test failure was fixed via wp-cli/package-command#83

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment