Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WP 4.4 requirement #4845

Merged
merged 4 commits into from Jul 16, 2018

Conversation

2 participants
@wojsmol
Copy link
Contributor

wojsmol commented Jul 14, 2018

This PR removes WP 4.4 requirement from skip-theme test by using stargazer and buntu themes.

wojsmol added some commits Jul 14, 2018

@wojsmol wojsmol force-pushed the wojsmol:remove-require-wp-44 branch from 76e7e97 to 5d61e32 Jul 15, 2018

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Jul 16, 2018

@wojsmol The tests fail because your check (whether the function theme_setup exists) is wrong.
The parent theme you've picked is built using objects, not using procedural code. So your check needs to look for a class or method, not a function. Use something like the following:

// For stargazer parent theme:
wp eval 'var_export( class_exists( "Stargazer_Theme" ) );'
// For buntu child theme:
wp eval 'var_export( function_exists( "buntu_theme_setup" ) );'
@wojsmol

This comment has been minimized.

Copy link
Contributor Author

wojsmol commented Jul 16, 2018

should be fixed now - thanks

fix

@schlessera schlessera added this to the 2.0.0 milestone Jul 16, 2018

@schlessera schlessera merged commit b0b4462 into wp-cli:master Jul 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Jul 16, 2018

Thanks for your continued effort on this, @wojsmol !

@wojsmol wojsmol deleted the wojsmol:remove-require-wp-44 branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.