New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to full string instead of $mode on PHP < 7 #4853

Merged
merged 2 commits into from Jul 19, 2018

Conversation

2 participants
@schlessera
Member

schlessera commented Jul 19, 2018

Fixes #4852

@schlessera schlessera added this to the 2.0.0 milestone Jul 19, 2018

@schlessera schlessera merged commit ade39da into master Jul 19, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@schlessera schlessera deleted the 4852-php-uname-mode-fallback branch Jul 19, 2018

$shell = getenv( 'SHELL' );
// php_uname() $mode argument was only added with PHP 7.0+. Fall back to
// entire string for older versions.
$system_os = PHP_MAJOR_VERSION >= 7

This comment has been minimized.

@chesio

chesio Jul 19, 2018

Contributor

Shouldn't the comparison be reversed here, ie. PHP_MAJOR_VERSION < 7?

@chesio

chesio Jul 19, 2018

Contributor

Shouldn't the comparison be reversed here, ie. PHP_MAJOR_VERSION < 7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment