New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inflector class and convenience function for pluralizing nouns #4881

Merged
merged 4 commits into from Aug 3, 2018

Conversation

3 participants
@schlessera
Member

schlessera commented Aug 3, 2018

Fixes #4880

@schlessera schlessera requested a review from wp-cli/committers Aug 3, 2018

@schlessera schlessera added this to the 2.0.0 milestone Aug 3, 2018

@wojsmol

This comment has been minimized.

Show comment
Hide comment
@wojsmol

wojsmol Aug 3, 2018

Contributor

@schlessera IMHO no need for public here

public function pluralize( $noun, $count = null ) {

Contributor

wojsmol commented Aug 3, 2018

@schlessera IMHO no need for public here

public function pluralize( $noun, $count = null ) {

schlessera added some commits Aug 3, 2018

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 3, 2018

Member

I'm adding tests as well now...

Member

schlessera commented Aug 3, 2018

I'm adding tests as well now...

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 3, 2018

Member

This should be good to go now.

Member

schlessera commented Aug 3, 2018

This should be good to go now.

@schlessera schlessera merged commit b32cd0f into master Aug 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the 4880-add-inflector branch Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment