New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert 'install' to 'installation' #4946

Merged
merged 9 commits into from Sep 19, 2018

Conversation

5 participants
@KushibikiMashu
Copy link
Contributor

KushibikiMashu commented Sep 14, 2018

For #4541 ("installation" instead of "install")

@swissspidy

This comment has been minimized.

Copy link
Contributor

swissspidy commented Sep 14, 2018

Thanks for the PR!

I just noticed that there are a few more instances of "WordPress install" instead of "WordPress installation" (e.g. No WordPress install found) in the following files:

  • features/config.feature
  • features/help.feature
  • php/config-spec.php
  • php/WP_CLI/Runner.php

Wanna change these as well while you are at it? 🙂

@KushibikiMashu

This comment has been minimized.

Copy link
Contributor

KushibikiMashu commented Sep 14, 2018

@swissspidy Thank you for your advise!
I'll check these files and give some commits during WordCamp Tokyo😄

@KushibikiMashu

This comment has been minimized.

Copy link
Contributor

KushibikiMashu commented Sep 14, 2018

@swissspidy Hi!
I read Travis log and tried to modify the code to resolve the problem in failing.
I'll try to run behat test locally and examine the code in detail😅

@wojsmol wojsmol referenced this pull request Sep 14, 2018

Merged

fixig alias tests #1

@wojsmol

This comment has been minimized.

Copy link
Contributor

wojsmol commented Sep 14, 2018

@KushibikiMashu Please see my PR to your branch.

@wojsmol

This comment has been minimized.

Copy link
Contributor

wojsmol commented Sep 15, 2018

@KushibikiMashu Please see KushibikiMashu#2 for remaining tests fixes.

schlessera added some commits Sep 19, 2018

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Sep 19, 2018

Thanks for the pull request, @KushibikiMashu!

@schlessera schlessera merged commit 3caf201 into wp-cli:master Sep 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera added this to the 2.1.0 milestone Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment