New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "installation" instead of "install" in documentation #4960

Merged
merged 1 commit into from Oct 30, 2018

Conversation

3 participants
@henrywright
Copy link
Contributor

henrywright commented Oct 2, 2018

This PR uses the noun where appropriate. Please note only documentation is addressed, not code or tests. PR is a response to https://twitter.com/wpcli/status/1047158732805853184

#Hacktoberfest

@henrywright

This comment has been minimized.

Copy link
Contributor

henrywright commented Oct 2, 2018

Partially addresses #4541

@mkdizajn
Copy link

mkdizajn left a comment

All looks good

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Oct 3, 2018

This will require changes in some of the feature tests.

They might be using something like the following:

And STDERR contains:
"""
Error: This is not a multisite install.
"""

The easiest fix will be to remove the period (.) at the end of those entries in the feature tests, as they will then match both old and new versions of the error message.

@henrywright Do you feel up to discovering the repos that need this change in the feature tests and submit issues/PRs as well?

@schlessera schlessera added this to the 2.1.0 milestone Oct 3, 2018

@henrywright

This comment has been minimized.

Copy link
Contributor

henrywright commented Oct 3, 2018

@schlessera schlessera merged commit 2aea783 into wp-cli:master Oct 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment