New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the way WordPress Core locates `wp-config.php` #4984

Merged
merged 3 commits into from Oct 30, 2018

Conversation

3 participants
@VladimirAus
Copy link
Contributor

VladimirAus commented Oct 27, 2018

Fix for #4856 Updated locate_wp_config() to match core.

@swissspidy

This comment has been minimized.

Copy link
Contributor

swissspidy commented Oct 27, 2018

Why the error silencing?

@VladimirAus

This comment has been minimized.

Copy link
Contributor

VladimirAus commented Oct 27, 2018

@swissspidy You need to be more specific. Who is silencing and which error?

@VladimirAus VladimirAus changed the title [#4856] Use `dirname()` instead of `..` to locate `wp-config.php` to match Core behavior. [#4856] WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. Oct 27, 2018

@VladimirAus VladimirAus changed the title [#4856] WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. #4856 WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. Oct 27, 2018

@VladimirAus VladimirAus changed the title #4856 WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. https://github.com/wp-cli/wp-cli/issues/4856 WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. Oct 27, 2018

@VladimirAus VladimirAus changed the title https://github.com/wp-cli/wp-cli/issues/4856 WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. #4856 WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. Oct 27, 2018

@VladimirAus VladimirAus changed the title #4856 WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. Oct 27, 2018

Show resolved Hide resolved php/utils.php Outdated
@swissspidy

This comment has been minimized.

Copy link
Contributor

swissspidy commented Oct 27, 2018

@VladimirAus My bad, I thought I had added this as an inline comment. Refined the question now.

@schlessera schlessera changed the title WP-CLI does not use the same way as wordpress to locate the `wp-config.php`. Match the way WordPress Core locates `wp-config.php` Oct 30, 2018

@schlessera schlessera added this to the 2.1.0 milestone Oct 30, 2018

@schlessera schlessera merged commit 32b560c into wp-cli:master Oct 30, 2018

2 checks passed

DEP All dependencies are resolved
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Oct 30, 2018

Thanks for the PR, @VladimirAus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment