New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of arguments for `WP_CLI::runcommand()` with `launch=false` #4989

Merged
merged 3 commits into from Oct 31, 2018

Conversation

2 participants
@schlessera
Copy link
Member

schlessera commented Oct 31, 2018

I added unit tests for the broken cases and modified the regular expression so that it correctly parses these cases as well.

Fixes #4741

@schlessera schlessera changed the title WIP - Fix parsing of arguments for `WP_CLI::runcommand()` with `launch=false` Fix parsing of arguments for `WP_CLI::runcommand()` with `launch=false` Oct 31, 2018

@schlessera schlessera requested a review from wp-cli/committers Oct 31, 2018

@danielbachhuber

This comment has been minimized.

Copy link
Member

danielbachhuber commented Oct 31, 2018

@schlessera Were the first two builds supposed to fail?

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Oct 31, 2018

@danielbachhuber Not sure what you mean. All commits were meant to pass and did pass, but the second one added edge cases the first one didn't test against.
Third one is just a simplification.

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Oct 31, 2018

Oh, and the tests do fail with the original regex.

@danielbachhuber

This comment has been minimized.

Copy link
Member

danielbachhuber commented Oct 31, 2018

All commits were meant to pass and did pass, but the second one added edge cases the first one didn't test against.

Ok, cool. I've run into an issue before where Travis passed but I expected it to fail. Wanted to make sure it wasn't the case here.

@schlessera schlessera merged commit d6b5e02 into master Oct 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the 4741-quotes-misparsed-in-runcommand branch Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment