New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.0+: allow for changed list assignment order #5021

Merged
merged 1 commit into from Dec 12, 2018

Conversation

2 participants
@jrfnl
Copy link
Contributor

jrfnl commented Dec 9, 2018

The variables which are problematic are in actual fact not used in the code, but this was not clear just by looking at it.

By making the variables names more descriptive and unique, the PHP 7.0 issue is bypassed and the code is better auto-documented.

PHP 7.0+: allow for changed list assignment order
The variables which are problematic are in actual fact not used in the code, but this was not clear just by looking at it.

By making the variables names more descriptive and unique, the PHP 7.0 issue is bypassed and the code is better auto-documented.

@jrfnl jrfnl force-pushed the jrfnl:feature/php-7-compat branch from fabacfa to 89e4b22 Dec 9, 2018

@schlessera schlessera added this to the 2.1.0 milestone Dec 12, 2018

@schlessera schlessera merged commit 8490a3e into wp-cli:master Dec 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jrfnl jrfnl deleted the jrfnl:feature/php-7-compat branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment