Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `WP_CLI::has_config()` method #5063

Merged
merged 21 commits into from Jan 25, 2019

Conversation

@killua99
Copy link
Contributor

commented Jan 23, 2019

New wp cli api to validate that a global configuration does exists.

Related #4954

Luigi Guevara and others added some commits Jan 23, 2019

php/class-wp-cli.php Outdated Show resolved Hide resolved
features/cli.feature Outdated Show resolved Hide resolved
features/cli.feature Outdated Show resolved Hide resolved
features/cli.feature Outdated Show resolved Hide resolved
features/cli.feature Outdated Show resolved Hide resolved
features/cli.feature Outdated Show resolved Hide resolved
features/cli.feature Outdated Show resolved Hide resolved
features/cli.feature Outdated Show resolved Hide resolved
features/cli.feature Outdated Show resolved Hide resolved
features/cli.feature Outdated Show resolved Hide resolved
@schlessera

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

@killua99 The approach looks good. I added a few change requests, which are mostly about grammar only.

schlessera and others added some commits Jan 25, 2019

Update php/class-wp-cli.php
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update features/cli.feature
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update features/cli.feature
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update features/cli.feature
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update features/cli.feature
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update features/cli.feature
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update features/cli.feature
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update features/cli.feature
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update features/cli.feature
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update php/class-wp-cli.php
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
Update php/class-wp-cli.php
Co-Authored-By: killua99 <luigi.fox15@gmail.com>
@killua99

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

@schlessera Double check everything seems ok

@schlessera schlessera added this to the 2.2.0 milestone Jan 25, 2019

@schlessera schlessera merged commit 8f00923 into wp-cli:master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera changed the title Validate that global configuration does exists Add `WP_CLI::has_config()` method Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.