Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to include / exclude views in wp_get_table_names() #5128

Merged
merged 8 commits into from Apr 24, 2019

Conversation

@emirpprime
Copy link

commented Apr 5, 2019

Part one of a feature discussed in search-replace-command/issues/109 - adds new flags --views-only and --base-tables-only to restrict results.

Test coverage only included for use with --all-tables / --all-tables-with-prefix. This is because when these functions aren't passed wp_get_table_names() relies on retrieving tables names from $wpdb. I couldn't see how to register a view with / inject a view into $wpdb, so have left that test coverage out for now.

@emirpprime emirpprime requested a review from wp-cli/committers as a code owner Apr 5, 2019

features/utils-wp.feature Outdated Show resolved Hide resolved
features/utils-wp.feature Outdated Show resolved Hide resolved
php/utils-wp.php Show resolved Hide resolved
php/utils-wp.php Outdated Show resolved Hide resolved
php/utils-wp.php Outdated Show resolved Hide resolved
php/utils-wp.php Outdated Show resolved Hide resolved
php/utils-wp.php Outdated Show resolved Hide resolved

@schlessera schlessera added this to the 2.2.0 milestone Apr 24, 2019

@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Thanks for the PR, @emirpprime !

@schlessera schlessera merged commit af72f89 into wp-cli:master Apr 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.