Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Limit ranges of PHP versions #5142

Merged
merged 1 commit into from Apr 17, 2019

Conversation

@localheinz
Copy link
Contributor

commented Apr 16, 2019

This PR

  • limits the ranges of PHP versions this project can be installed with

💁‍♂️ We don't know yet whether this project will work with PHP 9000.

@localheinz localheinz requested a review from wp-cli/committers as a code owner Apr 16, 2019

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@localheinz Do these pull requests correlate with an existing issue? If not, can you open one first please?

@localheinz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

@danielbachhuber

No, they do not.

Is it necessary to open an issue for each pull request?

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Is it necessary to open an issue for each pull request?

For this particular pull request, no. For those like wp-cli/scaffold-command#211, it's generally preferred.

Here's the overview to our contributing process: https://make.wordpress.org/cli/handbook/#contributing

@localheinz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

@danielbachhuber

I took a look at https://make.wordpress.org/cli/handbook/pull-requests/:

  1. Search existing issues; if you can’t find anything related to what you want to work on, open a new issue in the appropriate repository so that you can get some initial feedback.
    1. Opening an issue before submitting a pull request helps us provide architectural and implementation guidance before you spend too much time on the code.

What kind of guidance would be necessary to decide whether PHP 7.3 should be added to the build matrix?

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

What kind of guidance would be necessary to decide whether PHP 7.3 should be added to the build matrix?

.travis.yml is duplicated across all of the command repos. I believe @schlessera has some scripting for it.

@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

@localheinz Thanks for the PRs. For the other one, let us please move the discussion over to that repo. I added a comment with more details about why a single PR is problematic in that case: wp-cli/scaffold-command#211 (comment)

@schlessera schlessera added this to the 2.2.0 milestone Apr 17, 2019

@schlessera schlessera merged commit a5a13d6 into wp-cli:master Apr 17, 2019

2 checks passed

DEP All dependencies are resolved
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@localheinz localheinz deleted the localheinz:fix/php branch Apr 18, 2019

@localheinz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

Thank you, @danielbachhuber and schlessera!

Perhaps this is also something that would make sense to apply to all repositories?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.