Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `aliases` subcommand for backwards compatibility #5194

Merged
merged 2 commits into from Apr 24, 2019

Conversation

@thrijith
Copy link
Member

commented Apr 24, 2019

This should allow running wp cli aliases again.

@thrijith thrijith requested a review from wp-cli/committers as a code owner Apr 24, 2019

@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

I think we need to come up with a different implementation for this, because with the current approach, we'll end up with two separate commands being visible, which will confuse people:

Image 2019-04-24 at 9 41 38 AM

We should use back_compat_conversions (link), to transform wp cli aliases into wp cli alias list instead.

And the tests should go into aliases.feature, not cli.feature.

@thrijith thrijith force-pushed the add-aliases-subcommand branch from 0c1204e to a36063b Apr 24, 2019

@schlessera schlessera added this to the 2.2.0 milestone Apr 24, 2019

@schlessera schlessera merged commit 589b918 into master Apr 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the add-aliases-subcommand branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.