Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bug-provoking test for a bug in WPDB that was fixed #5220

Merged
merged 3 commits into from May 28, 2019

Conversation

@schlessera
Copy link
Member

commented May 14, 2019

If I read the code and the test correctly, this is just testing for a bug that was now fixed with release 5.2 of WP Core.

Remove bug-provoking test for a bug in WPDB that was fixed
If I read the code and the test correctly, this is just testing for a bug that was now fixed with release 5.2 of WP Core.

@schlessera schlessera requested a review from wp-cli/committers as a code owner May 14, 2019

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@schlessera Looks like there's a couple more tests that need to be updated?

@schlessera

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

@danielbachhuber Yes, indeed. Will plow through them one by one, I guess...

schlessera added some commits May 28, 2019

@schlessera schlessera modified the milestones: 2.2.1, 2.3.0 May 28, 2019

@schlessera schlessera merged commit 860c0b3 into master May 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the fix-wpdb-error-trap-bug branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.