Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic retry by default on certificate validation error #5523

Merged
merged 9 commits into from May 10, 2021

Conversation

schlessera
Copy link
Member

@schlessera schlessera commented May 6, 2021

This PR disables the automatic retrying of Utils/http_request() that was skipping certificate validation.

The new default is to produce a hard error on certificate errors.

This PR also adds a new --insecure flag to the cli update command that turns this retrying back on when explicitly requested, which allows manually going back to the previous behavior.

Subsequent PRs on the command repositories will add a similar --insecure flag to the appropriate commands on the following repositories:

@schlessera schlessera force-pushed the fix/require-insecure-flag-for-http-retry branch from 25b6969 to 69a352b Compare May 10, 2021 15:01
@schlessera schlessera merged commit 6f4e5dd into master May 10, 2021
24 checks passed
@schlessera schlessera deleted the fix/require-insecure-flag-for-http-retry branch May 10, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant