Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

I added the command db import [--file] #75

Merged
merged 1 commit into from Mar 1, 2012

Conversation

2 participants

svaj commented Feb 29, 2012

I just simply added functionality to import a database dump, since db query would not handle i/o redirection / reading queries from a file.

Thanks for this great tool!

Owner

scribu commented Mar 1, 2012

I was planning on handling this in #55.

Anyway, I don't think the file name should be an associative parameter. Instead of:

wp db import --file=my_db.sql

you should just be able to write:

wp db import my_db.sql

svaj commented Mar 1, 2012

I had it act like db dump, using [DB_NAME].sql if no parameter was supplied. Wouldn't consistency across commands be beneficial?

Owner

scribu commented Mar 1, 2012

True. And I guess it's not that obvious that it should be a file name. Could also be the database name. Nevermind.

One other thing bugs me: wp db dump should actually be wp db export, to match wp db import, but I guess that's a different issue.

scribu pushed a commit that referenced this pull request Mar 1, 2012

Merge pull request #75 from svaj/master
add `db import [--file]` command

@scribu scribu merged commit ec414bf into wp-cli:master Mar 1, 2012

scribu added a commit that referenced this pull request Mar 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment