Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize the newline to prevent an issue coming from OSX #14

Merged
merged 6 commits into from Mar 16, 2019

Conversation

@andreamk
Copy link
Contributor

commented Feb 14, 2019

No description provided.

andreamk added some commits Feb 14, 2019

src/WPConfigTransformer.php Outdated Show resolved Hide resolved
src/WPConfigTransformer.php Outdated Show resolved Hide resolved

@schlessera schlessera added the bug label Feb 19, 2019

@schlessera schlessera added this to the 1.2.5 milestone Feb 19, 2019

schlessera and others added some commits Mar 16, 2019

Update src/WPConfigTransformer.php
Co-Authored-By: andreamk <a.leoni@amkdeveloper.com>
Update src/WPConfigTransformer.php
Co-Authored-By: andreamk <a.leoni@amkdeveloper.com>
@andreamk

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

I updated the pull request.
Now it can be merged

Please tell me if there's anything else

andreamk added some commits Mar 16, 2019

@schlessera

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

Oh, I wasn't aware we were still testing for PHP 5.3 in this library. I'll discuss with @fjarrett whether we should maybe drop that.

I'll merge this with the old array syntax for now.

Thanks for the PR, @andreamk!

@schlessera schlessera merged commit 7a4b8c5 into wp-cli:master Mar 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fjarrett

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@andreamk What exactly was the issue being fixed here? All of my wp-config.php files are now double-spaced after running set commands...

@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@fjarrett Double-spaced as in "an extra newline in-between lines of code"? The change above should actually do the opposite...

@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@fjarrett What system are you running this on? On my Mac, set still works as expected, and tests in Travis are passing as well...

@andreamk

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Sorry for the delay in replying
this fix does not add double spaces but solves the problem with files edited with some editors on OSX.

I'm part of the staff that develops the Duplicator plugin and to find this problem we went crazy.
This change was tested and we found no problems.

Andrea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.