New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace test #8

Merged
merged 4 commits into from Oct 3, 2018

Conversation

3 participants
@bitwombat
Copy link

bitwombat commented Sep 13, 2018

It's pretty rough, so comment away.
It catches the bug that was fixed accidentally by ad435a7

Greg Bell added some commits Sep 13, 2018

@danielbachhuber

This comment has been minimized.

Copy link
Member

danielbachhuber commented Sep 13, 2018

It's pretty rough, so comment away.

Rough in what sense?

@danielbachhuber danielbachhuber added this to the 1.2.2 milestone Sep 13, 2018

$this->assertNotEquals( 'oldvalue', constant( 'DB_NAME' ), 'DB_NAME is still "oldvalue"' );
$this->assertEquals( 'newvalue', constant( 'DB_NAME' ), 'DB_NAME is not "newvalue"');
unlink( $test_config_path );

This comment has been minimized.

@schlessera

schlessera Sep 13, 2018

Member

You should use setUp and tearDown methods for creating and removing files like this. Otherwise, if the test fails, the file is not removed and might break the next test.

{
public function testConfigValues()
{
$test_config_path = __DIR__ . '/wp-config-test-update.php';

This comment has been minimized.

@schlessera

schlessera Sep 13, 2018

Member

Maybe rename the file to wp-config-test-multiline.php here.

@bitwombat

This comment has been minimized.

Copy link

bitwombat commented Sep 14, 2018

Have pushed changes as per comments.
Travis CI failed with what looks like a runtime error (ie. not my fault?)

@schlessera schlessera merged commit c469771 into wp-cli:master Oct 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bitwombat bitwombat deleted the bitwombat:whitespace-test branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment