Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bare product is added to the cart when the selected variation combination is unavailable #1373

Closed
jbeales opened this issue May 27, 2014 · 8 comments

Comments

Projects
None yet
4 participants
@jbeales
Copy link
Member

commented May 27, 2014

Best illustrated with a hypothetical example:

I sell shirts. They're available in Small, Medium, and Large, and Red, Green, and Blue. My manufacturer is a bit strange and refuses to make Blue shirts in Medium.

In WPEC I have a product called "Shirt," it has variations for size & colour, and I have deleted the Medium Blue option. If a customer tries to choose a Medium Blue shirt with the select fields a message is displayed saying that combination of variants is not available, but they can still add the product to the cart, and when it's added, it's added as "Shirt," not "Medium Blue Shirt," just "Shirt."

If something's not available we shouldn't allow it to be added to the cart.

@JustinSainton JustinSainton added this to the 3.9.0 milestone Sep 21, 2014

@JustinSainton

This comment has been minimized.

Copy link
Member

commented Sep 21, 2014

Agreed. Sorry for the late reply to this, but would gladly welcome a PR (Note: PR should ensure functionality works as expected for both 1.0 and 2.0 theme engine.)

@JustinSainton JustinSainton modified the milestones: 4.0, 3.9.0 Oct 15, 2014

@JustinSainton

This comment has been minimized.

Copy link
Member

commented Dec 21, 2014

@jbeales You want to tackle this for 4.0?

@jbeales

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2014

When is that supposed to happen? I'm incredibly busy until mid-January.

On Sun, Dec 21, 2014 at 1:52 AM, Justin Sainton notifications@github.com
wrote:

@jbeales https://github.com/jbeales You want to tackle this for 4.0?


Reply to this email directly or view it on GitHub
#1373 (comment)
.

@JustinSainton

This comment has been minimized.

Copy link
Member

commented Dec 21, 2014

I'd like to see it released no later than the end of January, at or close to beta by early January. If you're able to get to it, awesome! If not, no problem at all. Someone else can pick it up, I may get to it, or it will get punted.

Thanks John!

@jbeales

This comment has been minimized.

Copy link
Member Author

commented Dec 24, 2014

Ok. I can't commit to making it happen in January, if I can, I will, but if
not we'll have to punt or have someone else cover it.

On Sun, Dec 21, 2014 at 5:31 PM, Justin Sainton notifications@github.com
wrote:

I'd like to see it released no later than the end of January, at or close
to beta by early January. If you're able to get to it, awesome! If not, no
problem at all. Someone else can pick it up, I may get to it, or it will
get punted.

Thanks John!


Reply to this email directly or view it on GitHub
#1373 (comment)
.

@pixelnix

This comment has been minimized.

Copy link

commented Apr 13, 2015

+1, needs to be fixed.

@misulicus

This comment has been minimized.

Copy link
Member

commented Apr 13, 2015

Wasn't this something that was related to the wpec theme files? I recall something with grid view mode

@JustinSainton

This comment has been minimized.

Copy link
Member

commented Jun 12, 2015

Confirmed this fails in both 1.0 and 2.0 theme engines.

JustinSainton added a commit that referenced this issue Jun 18, 2015

Fix #1373 for TEv2. Ensure that variations combinations that are tras…
…hed do not result in an addition to the cart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.