New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product is exempt from taxation admin checkbox #1685
Comments
@benhuson I think this occurs because of some of the quick edit commits. Reverting back to d4ad6ba fixes it. My hunch was that in the several areas across the commits where we're doing something like this: $post_data['meta']['_wpsc_product_metadata'] = wp_parse_args( $post_data['meta']['_wpsc_product_metadata'], array(
'engraved' => 0,
'can_have_uploaded_image' => 0
) ) ...it's probably overwriting parts the entire metadata array. So I dumped out the $post_data['meta'] in 3.8.14.4 and 3.9. Here's what it shows in 3.8.14.4 when unchecking the taxable box:
Note the lack of
Note: wpec_taxes_taxable is set to "on", even though it was unchecked. |
Fixes that issue, but now overwrites to unselected when doing quick edit. |
Above commit fixes issue uses nonce to prevent Quick Edit overwriting (like the other meta boxes). wp_parse_args() is used when saving product meta to ensure default values are set when no value is provided. This works fine providing it happens within a nonce check to ensure default values are only set when saving the main product page, not during quick edit where they would overwrite existing values. |
Should be, yep |
The checkbox can be checked but no unchecking
The text was updated successfully, but these errors were encountered: