New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

categories target countries. #1711

Closed
misulicus opened this Issue Dec 18, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@misulicus
Member

misulicus commented Dec 18, 2014

Just had the issue on a support request.
Checkout was just refreshing no errrors, no nothing.

Store -> Target countries -> USA only.

Product X that i`m trying to buy belongs to category A which has target markets set to USA.

When checking out page just refreshes. No errors no nada.
Selected target markets for category A to NONE and all is fixed.
Saw this thing million times.

@JustinSainton JustinSainton added this to the 3.9.2 milestone Dec 18, 2014

@JustinSainton

This comment has been minimized.

Show comment
Hide comment
@JustinSainton

JustinSainton Dec 19, 2014

Member

@misulicus Can't replicate this. Can we get some clearer steps to reproduce? Here's a screencast of it working fine for me.

http://quick.as/bqrs5oa

Feel free to re-open with steps to reproduce.

Member

JustinSainton commented Dec 19, 2014

@misulicus Can't replicate this. Can we get some clearer steps to reproduce? Here's a screencast of it working fine for me.

http://quick.as/bqrs5oa

Feel free to re-open with steps to reproduce.

@misulicus

This comment has been minimized.

Show comment
Hide comment
@misulicus

misulicus Feb 6, 2015

Member

Found a way to replicate.
Store target markets USA.
Use category A with target market USA.
Disable shipping fields on checkout page.
Add a product that belongs to category A to cart as guest. Enter data and select paypal standard for eaxmple.
Page will refresh no errors.

Fix is to edit category A and select NONE for target markets.
This is a "bug" that i`ve seeen soo many times.

Member

misulicus commented Feb 6, 2015

Found a way to replicate.
Store target markets USA.
Use category A with target market USA.
Disable shipping fields on checkout page.
Add a product that belongs to category A to cart as guest. Enter data and select paypal standard for eaxmple.
Page will refresh no errors.

Fix is to edit category A and select NONE for target markets.
This is a "bug" that i`ve seeen soo many times.

@misulicus

This comment has been minimized.

Show comment
Hide comment
@misulicus

misulicus Feb 6, 2015

Member

Ok did some debugging.
I believe using the example above the culprit is located here:
https://github.com/wp-e-commerce/WP-e-Commerce/blob/master/wpsc-components/theme-engine-v1/helpers/ajax.php#L602
till line 631

$is_valid is true right above that code and after it becomes valid so everything else afterwards fails, thus the page reload.

After that main foreach code i looked at the $errormessage variable and every time it shows:
string(114) "Test prod cannot be shipped to . To continue with your transaction please remove this product from the list below."

Where Test prod is my product name but as you can see the to "XX" the country is missing.

I believe that piece of code should check if Shipping fields are enabled or shipping in general.

Member

misulicus commented Feb 6, 2015

Ok did some debugging.
I believe using the example above the culprit is located here:
https://github.com/wp-e-commerce/WP-e-Commerce/blob/master/wpsc-components/theme-engine-v1/helpers/ajax.php#L602
till line 631

$is_valid is true right above that code and after it becomes valid so everything else afterwards fails, thus the page reload.

After that main foreach code i looked at the $errormessage variable and every time it shows:
string(114) "Test prod cannot be shipped to . To continue with your transaction please remove this product from the list below."

Where Test prod is my product name but as you can see the to "XX" the country is missing.

I believe that piece of code should check if Shipping fields are enabled or shipping in general.

@JustinSainton JustinSainton reopened this Feb 6, 2015

JustinSainton added a commit that referenced this issue Mar 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment