Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

_wpsc_force_download_file should call ob_end_clean() #550

Open
domlat opened this Issue Jul 5, 2013 · 0 comments

Comments

Projects
None yet
2 participants

domlat commented Jul 5, 2013

As subject.
There are two issues that this will deal with.

  1. Some badly written themes seem to "leak" stuff into the output buffer. So throw it away before outputting the file to download.
  2. With large files output buffering can exhaust available memory.

So we probably need this at the beginning of _wpsc_force_download_file
while (ob_get_level()) {
ob_end_clean();
}

_wpsc_admin_download_file and wpsc_download_file both call _wpsc_force_download_file so that seems the best place to do this.

@JustinSainton JustinSainton modified the milestones: 4.0, 3.9.0 Oct 15, 2014

@JustinSainton JustinSainton modified the milestones: Future Release, 4.0 Jun 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment