Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds GraphQL-Explorer to WP-GraphiQL in the way gatsby is using it. #16

Merged

Conversation

@henrikwirth
Copy link
Contributor

commented Aug 13, 2019

Solving this feature request: #14

So here is a working example already, but with some issues. Queries are generated via URL decoding and this needs to be fixed. Also the styling is off and needs to be adapted.

Tasks:

  • Add explorer
  • Add styling for explorer
  • Make sure url encoding/decoding works properly
@henrikwirth

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@jasonbahl This works now. The only litte problem is that the URI decoding ends up have no line-breaks. So when you make a query and then use the same generated URI you will see it is without line-breaks. But it works and Prettify makes in pretty again. Maybe you have an idea about the URI-Decoding.

@jasonbahl

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@henrikwirth I'm checking this out now. Thanks for the PR!

Copy link
Contributor

left a comment

Yo! I got it working. 2 small changes, then run yarn build again and we can get this merged!

assets/app/src/App.js Show resolved Hide resolved
assets/app/src/App.js Outdated Show resolved Hide resolved
henrikwirth and others added 3 commits Aug 13, 2019
Co-Authored-By: Jason Bahl <jasonbahl@mac.com>
Co-Authored-By: Jason Bahl <jasonbahl@mac.com>
@henrikwirth henrikwirth marked this pull request as ready for review Aug 13, 2019
Copy link
Contributor

left a comment

Thanks! This is a fantastic addition to the plugin!

@jasonbahl jasonbahl merged commit 7c08302 into wp-graphql:master Aug 13, 2019
@henrikwirth henrikwirth deleted the henrikwirth:feature/graphiql-explorer-gatsby branch Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.