Skip to content

Conversation

@kidunot89
Copy link
Collaborator

@kidunot89 kidunot89 commented Jun 27, 2021

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Adds support for third-party order statuses.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version: v0.10.0
  • WPGraphQL Version: v1.4.3
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 self-assigned this Jun 27, 2021
@kidunot89 kidunot89 added this to the v0.10.1 milestone Jun 27, 2021
@kidunot89 kidunot89 added the enhancement New feature or request label Jun 27, 2021
@kidunot89 kidunot89 force-pushed the feature/third-party-order-status-support branch 3 times, most recently from c762695 to 7009a57 Compare July 5, 2021 19:02
'REFUNDED' => array( 'value' => 'refunded' ),
'FAILED' => array( 'value' => 'failed' ),
);
$statuses = \wc_get_order_statuses();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces must be used to indent lines; tabs are not allowed

);
$statuses = \wc_get_order_statuses();

$values = array();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces must be used to indent lines; tabs are not allowed

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 7009a57 and detected 37 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 37

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.1%.

View more on Code Climate.

@kidunot89 kidunot89 force-pushed the feature/third-party-order-status-support branch from 7009a57 to bcecbd6 Compare July 5, 2021 19:20
@kidunot89 kidunot89 merged commit 9bbb81e into wp-graphql:develop Jul 5, 2021
@kidunot89 kidunot89 deleted the feature/third-party-order-status-support branch July 5, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant