Skip to content

dev: remove deprecated usage of AbstractConnectionResolver::get_offset() - #760

Merged
kidunot89 merged 2 commits into
wp-graphql:developfrom
justlevine:dev/remove-deprecated-get_offset
Jul 19, 2023
Merged

kidunot89 merged 2 commits into
wp-graphql:developfrom
justlevine:dev/remove-deprecated-get_offset

Conversation

@justlevine

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

This PR removes the usage of AbstractConnectionResolver::get_offset(), which was deprecated from WPGraphQL in v1.9.0.

Instead of get_offset(), we use get_offset_for_cursor(), and rely on the graphql_after_cursor and graphql_before_cursor query args.

Additionally, the overloaded definitions of get_offset() were removed from local ConnectionResolvers as their output is identical to the parent method, sans the deprecation warning.

Does this close any currently open issues?

…

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

 PHP Deprecated:  Function WPGraphQL\Data\Connection\AbstractConnectionResolver::get_offset is <strong>deprecated</strong> since version 1.9.0! Use WPGraphQL\WooCommerce\Data\Connection\Product_Connection_Resolver::get_offset_for_cursor() instead.

Any other comments?

…

Where has this been tested?

  • WooGraphQL Version: 0.14.1
  • WPGraphQL Version: 1.14.6
  • WordPress Version: 6.2.2
  • WooCommerce Version: 7.8.2

@kidunot89
kidunot89 merged commit 920d0b2 into wp-graphql:develop Jul 19, 2023
@justlevine
justlevine deleted the dev/remove-deprecated-get_offset branch July 19, 2023 22:08
@kidunot89 kidunot89 added dev-ops PR resolves an issue or implements a feature related to the development process bugfix Implements bugfix and removed dev-ops PR resolves an issue or implements a feature related to the development process labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Implements bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants