Skip to content

fix: Product attributes label inconsistences + syntax errors fix - #771

Merged
kidunot89 merged 3 commits into
wp-graphql:developfrom
kidunot89:fix/minor-syntax-errors-fix
Jul 19, 2023
Merged

kidunot89 merged 3 commits into
wp-graphql:developfrom
kidunot89:fix/minor-syntax-errors-fix

Conversation

@kidunot89

@kidunot89 kidunot89 commented Jul 19, 2023 •

Copy link
Copy Markdown
Collaborator

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Breaking Change: Fixes inconsistency in label and name fields across different product attribute types.
  • Fixes error thrown when draft product is queried by an unauthorized user.
  • Fixes syntax error related to the WPGRAPHQL_WOOCOMMERCE_ENABLE_AUTH_URLS flag
  • Stricter check added for client_session_id retrieval.

Does this close any currently open issues?

…

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

…

Where has this been tested?

  • WooGraphQL Version: …
  • WPGraphQL Version: …
  • WordPress Version:
  • WooCommerce Version:

@kidunot89
kidunot89 force-pushed the fix/minor-syntax-errors-fix branch from 7744871 to 7ced080 Compare July 19, 2023 22:47
@kidunot89
kidunot89 merged commit e6be30e into wp-graphql:develop Jul 19, 2023
@kidunot89 kidunot89 added the breaking change Solution will break some older solutions label Jul 20, 2023
@kidunot89 kidunot89 changed the title fix: Several minor obscured syntax errors fix fix: Product attributes label inconsistences + syntax errors fix Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Solution will break some older solutions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant