fix: JWT Auth hooks now support WPGraphQL Headless Login #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
reviewed
Oct 15, 2023
Comment on lines
25
to
31
| if ( class_exists( '\WPGraphQL\JWT_Authentication\Auth' ) ) { | ||
| return '\WPGraphQL\JWT_Authentication\Auth'; | ||
| } elseif ( class_exists( \WPGraphQL\Login\Main::class ) ) { | ||
| return \WPGraphQL\Login\Auth\TokenManager::class; | ||
| } else { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
- class_exists() doesn't use a
\prefix. - using the string instead of
::classfor the check, so it doesn't error if the class doesnt exist. - Checking for the class that's actually used instead of the parent class.
- Early return to reduce the code complexity.
Suggested change
| if ( class_exists( '\WPGraphQL\JWT_Authentication\Auth' ) ) { | |
| return '\WPGraphQL\JWT_Authentication\Auth'; | |
| } elseif ( class_exists( \WPGraphQL\Login\Main::class ) ) { | |
| return \WPGraphQL\Login\Auth\TokenManager::class; | |
| } else { | |
| return null; | |
| } | |
| if ( class_exists( 'WPGraphQL\JWT_Authentication\Auth' ) ) { | |
| return \WPGraphQL\JWT_Authentication\Auth::class; | |
| } | |
| if ( class_exists( 'WPGraphQL\Login\Auth\TokenManager' ) ) { | |
| return \WPGraphQL\Login\Auth\TokenManager::class; | |
| } | |
| return null; |
| * | ||
| * @var \WP_Error|string|null $token | ||
| */ | ||
| $token = $auth_class::get_token( $user ); |
There was a problem hiding this comment.
It's WPGraphQL\Login\Auth\TokenManager::get_auth_token().
Can probably use a method_exists( $auth_class, ...) to call the correct method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
Updates the filters in
WPGraphQL\WooCommerce\JWT_Auth_Schema_Filtersto work with WPGraphQL Headless LoginDoes this close any currently open issues?
…
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
…
Where has this been tested?