Skip to content

fix: ProductAttributeEnum given default value, if no product attributes exist #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kidunot89
Copy link
Collaborator

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Fixes Enum type ProductAttributeEnum must define one or more values. error by not registering the ProductAttributeEnum if no product attributes exist.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 added the bugfix Implements bugfix label Oct 31, 2023
@kidunot89 kidunot89 changed the title fix: ProductAttributeEnum no longer registered if no attribute exist fix: ProductAttributeEnum given default value, if no product attributes exist Oct 31, 2023
@kidunot89 kidunot89 merged commit 228284d into wp-graphql:develop Nov 1, 2023
@kidunot89 kidunot89 deleted the fix/product-attribute-enum-fix branch November 1, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant