Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Inputs that expect an ID, should all be of the ID Type and should accept the Integer or Relay ID #109
In various Input args, we're currently setup to accept the WordPress ID as the input, but we should be accepting Global Relay IDs.
For example, the
Same goes for basically all inputs where the expected input is an ID
More examples, but not necessarily a comprehensive list
referenced this issue
Jan 9, 2019
I don't think we should necessarily stop accepting the database IDs as arguments. There are a lot of plugins out there which rely on linking to posts by their ID. For example I integrate with MB Relationships and FacetWP. I personally don't like the idea of using
I do think that there is scope for both input types. Perhaps we could come up with a naming standard where
@hsimah ya, I believe that if the Input type is ID that it can accept either an integer or a String, so we can have the same input field accept either the database ID or the Relay ID
Then let the execution handle what to do.
Like, during execution, as we handle the input we can check something like the following (pseudo code):