New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalSettings.startOfWeek throwing an error #528

Open
jasonbahl opened this Issue Sep 27, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@jasonbahl
Collaborator

jasonbahl commented Sep 27, 2018

The following query:

query {             
    generalSettings {
        dateFormat
        description
        language
        startOfWeek
        timeFormat
        timezone
        title
    }
}

Returns an error:

{
      "debugMessage": "Int cannot represent non 32-bit signed integer value: (empty string)",
      "message": "Internal server error",
      "category": "internal",
      "locations": [
        {
          "line": 6,
          "column": 5
        }
      ],
      "path": [
        "generalSettings",
        "startOfWeek"
      ]
    }
  ]
@adioe3

This comment has been minimized.

Show comment
Hide comment
@adioe3

adioe3 Oct 1, 2018

I'd like to take care of this, will prep a PR this week.

adioe3 commented Oct 1, 2018

I'd like to take care of this, will prep a PR this week.

@jasonbahl

This comment has been minimized.

Show comment
Hide comment
@jasonbahl

jasonbahl Oct 1, 2018

Collaborator

@adioe3 thanks! let me know if you need to discuss anything while you're working on it.

Collaborator

jasonbahl commented Oct 1, 2018

@adioe3 thanks! let me know if you need to discuss anything while you're working on it.

@zilehuda

This comment has been minimized.

Show comment
Hide comment
@zilehuda

zilehuda Oct 11, 2018

is this open ?

zilehuda commented Oct 11, 2018

is this open ?

@jasonbahl

This comment has been minimized.

Show comment
Hide comment
@jasonbahl

jasonbahl Oct 11, 2018

Collaborator

@zilehuda Yes. There have not been any pull requests to address this yet.

Collaborator

jasonbahl commented Oct 11, 2018

@zilehuda Yes. There have not been any pull requests to address this yet.

@tryvin

This comment has been minimized.

Show comment
Hide comment
@tryvin

tryvin Oct 20, 2018

@jasonbahl Steps to reproduce this? The tests units say it's all ok, no issues with the generalSettings > startOfWeek

tryvin commented Oct 20, 2018

@jasonbahl Steps to reproduce this? The tests units say it's all ok, no issues with the generalSettings > startOfWeek

@davidatwhiletrue

This comment has been minimized.

Show comment
Hide comment
@davidatwhiletrue

davidatwhiletrue Oct 21, 2018

Hello, I'm able to reproduce this if you set in your WordPress settings Sunday as first day of week. For others, like Monday, it is working fine.

Choosing Sunday leads to option start_of_week get value 0.

In SettingType.php Ln136, value 0 is substituted with empty string.

I'm preparing a PR to solve this.

davidatwhiletrue commented Oct 21, 2018

Hello, I'm able to reproduce this if you set in your WordPress settings Sunday as first day of week. For others, like Monday, it is working fine.

Choosing Sunday leads to option start_of_week get value 0.

In SettingType.php Ln136, value 0 is substituted with empty string.

I'm preparing a PR to solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment