Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Setup postdata on field levels #714
It does not use it because the
I don't know how this should be really fixed but adding this to the
but I'm pretty sure it's not the right solution so I didn't include it in this PR.
UPDATE: I have now added a proper fix to this PR
Where has this been tested?
The latest dev branch.
@@ Coverage Diff @@ ## develop #714 +/- ## =========================================== + Coverage 60.12% 60.14% +0.01% =========================================== Files 110 110 Lines 6741 6744 +3 =========================================== + Hits 4053 4056 +3 Misses 2688 2688
Did some more digging and found
I'm pretty sure this is too early to call it because during the testPostExcerptsAreDifferent test it is called immediately for both test posts before the excerpt resolvers are called so it makes sense it returns wrong values because the last one "gets stuck" there for all resolver calls.
In the InstrumentSchema's
So I've added an commit that removes
So yeah... I basically rewrote this PR. We found more bugs when
So this PR now rewrites how WPGraphQL calls setup_postdata. It's now done on the field level.