Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuLocationEnum fix #716



None yet
2 participants
Copy link

commented Mar 9, 2019

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Makes menu locations without assigned menus visible to MenuLocationEnum. Relies on $_wp_registered_nav_menus global, instead of get_nav_menu_locations().

Does this close any currently open issues?


Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.0.2


This comment has been minimized.

Copy link

commented Mar 9, 2019

Codecov Report

Merging #716 into develop will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #716      +/-   ##
+ Coverage    60.12%   60.12%   +<.01%     
  Files          110      110              
  Lines         6738     6741       +3     
+ Hits          4051     4053       +2     
- Misses        2687     2688       +1
Impacted Files Coverage Δ
src/Type/Enum/MenuLocationEnum.php 66.66% <100%> (ø) ⬆️
src/Data/DataSource.php 83.55% <66.66%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ca28a...e23688a. Read the comment docs.

@jasonbahl jasonbahl self-requested a review Mar 11, 2019


This comment has been minimized.

Copy link

commented Mar 11, 2019

@kidunot89 good change! Thanks!

@jasonbahl jasonbahl merged commit 7750d33 into wp-graphql:develop Mar 11, 2019

3 checks passed

codecov/patch 80% of diff hit (target 60.12%)
codecov/project 60.12% (+<.01%) compared to c9ca28a
continuous-integration/travis-ci/pr The Travis CI build passed

@jasonbahl jasonbahl added this to the 0.2.3 milestone Mar 18, 2019

This was referenced Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.