Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widget_update_callback and Elementor - Cache cleared on every page load #1485

Closed
arunbasillal opened this issue Jan 18, 2019 · 3 comments

Comments

@arunbasillal
Copy link
Contributor

commented Jan 18, 2019

We have been seeing some issues lately where cache was being cleared on every page load because of calling rocket_clean_domain() via the widget_update_callback filter.

@webtrainingwheels observed that all reported cases used Elementor.

I just tested this on a staging site and found it to be true.

Elementor uses the filter:
https://github.com/pojome/elementor/blob/73a598fb0dc7c97322ce351d71fdf8db2597e319/includes/widgets/wordpress.php#L207

Elementor Issue: elementor/elementor#5844

HS tag: widget_update_callback

Helper plugin to fix - https://github.com/wp-media/wp-rocket-helpers/tree/master/cache/wp-rocket-no-cache-purge-widget-update

@webtrainingwheels

This comment has been minimized.

Copy link

commented Feb 26, 2019

Just another observation - this can be a really bad combo when Autoptimize is active too. AO listens for cache clearing and it can result in server overload. Similar to: futtta/autoptimize#195
examples:
https://secure.helpscout.net/conversation/787623167/98174?folderId=377611
https://secure.helpscout.net/conversation/781294692/96991/?folderId=273766

@Tabrisrp Tabrisrp self-assigned this Mar 18, 2019

@Tabrisrp Tabrisrp added this to the 3.3.1 milestone Mar 18, 2019

@Tabrisrp Tabrisrp moved this from Triage to Planned for next version in Support Wishlist Mar 18, 2019

@Tabrisrp

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

Removing the action on widget_update_callback if Elementor is active seems to be the most straightforward solution. Do you see any other one?

@arunbasillal

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Can't think of anything better either and that seems to have the least impact overall. 👍

@Tabrisrp Tabrisrp moved this from Planned for next version to In progress in Support Wishlist Apr 5, 2019

@Tabrisrp Tabrisrp referenced this issue Apr 16, 2019

Merged

3.3.1 #1648

@Tabrisrp Tabrisrp closed this in d61d599 Apr 16, 2019

Support Wishlist automation moved this from In progress to Done Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.