Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical CSS notices: add doc link #1512

Closed
webtrainingwheels opened this issue Feb 1, 2019 · 4 comments

Comments

@webtrainingwheels
Copy link

commented Feb 1, 2019

Could we add a link to the below doc into the notices about critical CSS generation:
https://docs.wp-rocket.me/article/108-render-blocking-javascript-and-css-pagespeed#errors

@Tabrisrp Tabrisrp added this to Triage in Support Wishlist Feb 11, 2019

@Tabrisrp Tabrisrp self-assigned this Mar 18, 2019

@Tabrisrp Tabrisrp added this to the 3.3.1 milestone Mar 18, 2019

@Tabrisrp Tabrisrp moved this from Triage to Planned for next version in Support Wishlist Mar 18, 2019

@Tabrisrp

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

What should be the label for the link? @ernee

@ernee

This comment has been minimized.

Copy link

commented Apr 2, 2019

@Tabrisrp appending Learn more. to the error notices like we have previously could work.

For example our Preload error notices:

Screen Shot 2019-04-01 at 6 22 17 PM

@Tabrisrp Tabrisrp moved this from Planned for next version to In progress in Support Wishlist Apr 5, 2019

@webtrainingwheels

This comment has been minimized.

Copy link
Author

commented Apr 10, 2019

Here's how it currently looks:
WP_Rocket_‹Mission_Control—_WordPress

I think we need a bit more text for context, along with "Learn more". As I see it, we could either:

  1. Place one Learn More link at the bottom of the notice.
    or
  2. Place a Learn More link next to every URL that errors. That could be a bit much if there's a lot of URLs that error. On the pro side, this could be valuable if we could link to the specific section in the doc for the specific error type. But this will require more work than I think we have time for currently.

I think we should start with option 1 since it's much easier/faster for now.

Proposal:
Critical CSS generation encountered one or more errors. Learn more.

If there's a way to detect if there was only 1 error vs multiple errors, I can provide different text. Here I've tried to cover both possibilities in one.

@Tabrisrp

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Currently I don't have a counter for the number of errors, so this proposal is the best choice.

@Tabrisrp Tabrisrp referenced this issue Apr 16, 2019

Merged

3.3.1 #1648

@Tabrisrp Tabrisrp closed this in 22adfa1 Apr 16, 2019

Support Wishlist automation moved this from In progress to Done Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.