Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error when Rank Math XML sitemap for preloading #1620

Closed
girlie opened this issue Apr 8, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@girlie
Copy link

commented Apr 8, 2019

PHP Fatal error: Class 'RankMath\Modules\Sitemap\Router' not found in /wp-content/plugins/wp-rocket/inc/3rd-party/plugins/seo/rank-math-seo.php on line 86

In the Rank Math SEO plugin code, they're retrieving the sitemap URL like this:

return \RankMath\Sitemap\Router::get_base_url( 'sitemap_index.xml' );

whereas we're doing it like this:

$sitemaps[] = \RankMath\Modules\Sitemap\Router::get_base_url( 'sitemap_index.xml' );

So I just took the \Modules bit out of that line on my test site, which seems to have fixed the problem.

@webtrainingwheels

This comment has been minimized.

Copy link

commented Apr 9, 2019

HS tag: rank math seo

@Tabrisrp

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

@MyThemeShop did your code change between #1445 and now?

@MyThemeShop

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Hello @here

We have created a pull request, which should fix the issue:
#1629

Thank you.

@Tabrisrp Tabrisrp added this to the 3.3.1 milestone Apr 12, 2019

@Tabrisrp Tabrisrp self-assigned this Apr 12, 2019

@Tabrisrp Tabrisrp referenced this issue Apr 16, 2019

Merged

3.3.1 #1648

@Tabrisrp Tabrisrp closed this in 4678068 Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.