Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Beacon 2.0 #1580

Merged
merged 4 commits into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@Tabrisrp
Copy link
Contributor

commented Mar 18, 2019

Integrate the new Beacon version into the plugin

@Tabrisrp Tabrisrp added this to the 3.3.1 milestone Mar 18, 2019

@Tabrisrp Tabrisrp self-assigned this Mar 18, 2019

@Tabrisrp Tabrisrp requested a review from Screenfeed Mar 18, 2019

@Screenfeed Screenfeed merged commit 4d6a154 into branch-3.3.1 Mar 18, 2019

@Screenfeed Screenfeed deleted the enhancement/beacon2 branch Mar 18, 2019

@webtrainingwheels

This comment has been minimized.

Copy link

commented Apr 10, 2019

Is there anything we can do about this?

WP_Rocket_‹WordPress_Themes—_WordPress

On my 13" MacBookPro, if I have either of the Bookmarks Bar or Downloads bar displayed (which normally they are), it hides the top of the Beacon.

@webtrainingwheels

This comment has been minimized.

Copy link

commented Apr 10, 2019

For comparison, with both bookmarks and downloads off:
WP_Rocket_‹WordPress_Themes—_WordPress

still a bit overlapped, but at least legible.

@Screenfeed

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Put your screen vertically.

@Tabrisrp

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Unfortunately we can't control the dimensions of the box

@Tabrisrp Tabrisrp referenced this pull request Apr 16, 2019

Merged

3.3.1 #1648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.