Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1707 Autoptimize & Avada lazyload compatibility #1739

Merged
merged 5 commits into from May 28, 2019

Conversation

Projects
None yet
2 participants
@Tabrisrp
Copy link
Contributor

commented May 21, 2019

Deactivate WP Rocket lazyload if Autoptimize or Avada lazyload is enabled

@Tabrisrp Tabrisrp added this to the 3.3.4 milestone May 21, 2019

@Tabrisrp Tabrisrp requested a review from Screenfeed May 21, 2019

@Tabrisrp Tabrisrp self-assigned this May 21, 2019

Show resolved Hide resolved inc/3rd-party/plugins/autoptimize.php Outdated
Show resolved Hide resolved inc/3rd-party/plugins/autoptimize.php Outdated
Show resolved Hide resolved inc/3rd-party/plugins/autoptimize.php Outdated
Show resolved Hide resolved inc/3rd-party/themes/avada.php Outdated
Show resolved Hide resolved inc/3rd-party/themes/avada.php Outdated
*
* @return bool
*/
function rocket_maybe_disable_lazyload() {

This comment has been minimized.

Copy link
@Screenfeed

Screenfeed May 28, 2019

Contributor

Shouldn't functions related to Autoptimize be named accordingly? Like rocket_autoptimize_maybe_disable_lazyload().

This comment has been minimized.

Copy link
@Tabrisrp

Tabrisrp May 28, 2019

Author Contributor

the previous functions were already named that way so I kept the same schema

Apply suggestions from code review
Co-Authored-By: Grégory Viguier <Screenfeed@users.noreply.github.com>

@Screenfeed Screenfeed merged commit 305b9f3 into develop May 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Screenfeed Screenfeed deleted the fix/1707-lazyload-compatibility branch May 28, 2019

@Tabrisrp Tabrisrp referenced this pull request Jun 4, 2019

Merged

3.3.4 #1754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.