Hotfix: Prevent PHP fatal error when trying to delete a term #2650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function WP_Rocket\Engine\Cache\PurgeActionsSubscriber::maybe_purge_cache_on_term_change(), 2 passed in /home/aswakdriwr/delivery/wp-includes/class-wp-hook.
This happens because
pre_delete_terms
uses 2 arguments only. I used this hook at the start of the work on the PR, then noticed I could usedelete_term
instead, and forgot to update the hook name inget_subscribed_events()
.The error wasn't reported during QA.
delete_term
instead ofpre_delete_term
hook