Skip to content
Permalink
Browse files

Added a composer.json file.

  • Loading branch information
remcotolsma committed Jun 26, 2018
1 parent eec4054 commit 42f34c40fc9ee8bff4f716e30ba87149cb33f28e
Showing with 8 additions and 0 deletions.
  1. +8 −0 composer.json
@@ -0,0 +1,8 @@
{
"name": "wp-premium/gravityforms",
"autoload": {
"classmap": [
"."
]
}
}

6 comments on commit 42f34c4

@drzraf

This comment has been minimized.

Copy link

drzraf replied Jul 13, 2018

That was a good idea. Any plan to extend this to other repositories?
One missing field is the "type:wordpress-plugin" , because it allows putting the directory inside a specific location.
See https://getcomposer.org/doc/faqs/how-do-i-install-a-package-to-a-custom-path-for-my-framework.md

@carlhancock

This comment has been minimized.

Copy link

carlhancock replied Jul 13, 2018

@remcotolsma This repo has been around for a long time as an unofficial mirror. One thing I want to mention after this commit was brought to my attention is once you begin making code changes to the Gravity Forms code base this repository is no longer an unofficial mirror, it's a fork.

Once it's a fork you will need to completely change the name as well as completely strip the Gravity Forms trademark from the codebase itself. That would include the name, "gravityforms" in the code, etc.

If there is some reason Pronamic (or other Gravity Forms developers for that matter) need access to Gravity Forms via Github we'd be glad to discuss giving you access to the official Gravity Forms repo on Github. While it is currently a private repo, we do grant access to Gravity Forms developers who have been vetted. We are also considering opening up that repo to the public down the road.

I just wanted to reach out to you directly here as this commit had been brought to my attention and it appears to be taking steps towards being more than an unofficial mirror which poses license, trademark and brand confusion issues. You can reach me directly via my carl at rocketgenius.com email address to discuss further if you would like.

@drzraf

This comment has been minimized.

Copy link

drzraf replied Jul 13, 2018

Any serious developer needs access to releases through Composer + GitHub/GitLab and wp-premium is a godsend for all of us who, having bought the license for the product (be it ACF-pro or GF*), still need to deploy them in a professional way.

About trademark:
Nothing: https://euipo.europa.eu/eSearch/#basic/1+1+1+1/100+100+100+100/gravityforms
Nothing: http://tmsearch.uspto.gov/bin/showfield?f=toc&state=4802%3A2nvadx.1.1&p_search=searchss&p_L=50&BackReference=&p_plural=yes&p_s_PARA1=&p_tagrepl%7E%3A=PARA1%24LD&expr=PARA1+AND+PARA2&p_s_PARA2=gravityforms&p_tagrepl%7E%3A=PARA2%24COMB&p_op_ALL=AND&a_default=search&a_search=Submit+Query&a_search=Submit+Query

@remcotolsma
find . -name '*gravityforms*' | while read f; do git mv "$f" "${f/gravityforms/gravityfoo}"; done
git grep -l gravityforms|xargs -n1 echo sed -i -e 's/gravityforms/gravityfoo/' -e 's/Gravity Forms/Gravity Foo/'

but rocketgenius providing composer-friendly releases, be it via GitHub or via semi-private Satis instance would be a far better solution (and hopefully offering a way for PR contributions)

@carlhancock

This comment has been minimized.

Copy link

carlhancock replied Jul 13, 2018

@drzraf You aren't searching the correct place for federal trademarks. The USPTO site isn't so user friendly so it's easy to search the wrong place. But rest assured it's an active registered trademark. It's USPTO serial number is #86114563 and it's USPTO registration number is #4563308.

My comment was not meant to start an argument on what developers do and don't need. It was to broach the subject of code changes and trademark in a friendly manner. If we wanted to do so in a non-friendly way we would have simply approached Github directly and had them take it down. But we do not want to do that.

As the holder of the trademark and copyright the onus is on us as a company to point out that when you start making code changes to the codebase in an unofficial mirror it ceases being a mirror and becomes a fork and with that comes additional requirements from a licensing and trademark standpoint.

Side note... changing the name from "Gravity Forms" to "Gravity Foo" would do nothing from a trademark standpoint. Basically if it's forms related and it has "Gravity" in the name it wouldn't fly from a legal standpoint due to how trademarks work and how they are designed to help protect from confusion in the marketplace. But that isn't the subject of my comment here nor should it be the subject of the conversation at hand. The subject is to address a mirror distributing changed version of the code without officially forking the codebase and making the necessary trademark changes to be compliant with trademark and licensing.

The reason this mirror has existed without issue is precisely because code changes had not been made. Once code changes are made it changes the dynamics from a legal standpoint. The legalities may suck, but it's something that has to be brought up because as a trademark and copyright holder we have a legal obligation to bring it up.

Gravity Forms has a Github repository but it is currently private as I mentioned. However, we do grant access to developers who request it on a case by case basis. We just haven't opened it up globally just yet as we don't have the bandwidth to deal with the volume of PR's and other such requests that would sure to follow. But we do actively have 3rd party developers who have access to the repo and do actively contribute to the Gravity Forms codebase via PR's and commits. If you (or any other user of this repo) would like access to the official Gravity Forms repo simply reach out to us directly.

@carlhancock

This comment has been minimized.

Copy link

carlhancock replied Jul 13, 2018

@drzraf To sum it the above... if Github access with composer-friendly releases is something you (or other) developers need you should reach out to us and work with us to make it happen rather than working against us. We want to make things easier for developers. But we need to do things the right way from a legal, licensing and trademark standpoint.

Currently the main Gravity Forms Github repo is not composer friendly because we have a build process that takes place as well as code tests and Travis CI build process that occurs. It's not composer friendly out of the box because of that. But a composer friendly repo is something we are open to exploring but it would have to be done in an official capacity from a licensing, trademark and IP standpoint because of the code changes that would need to take place to make it happen.

Another thing to note, you can interact and get Gravity Forms using WP-CLI. Which is an alternative to pulling directly from Github via Composer. I know that isn't ideal for everyone. But it is something that is possible right now.

@drzraf

This comment has been minimized.

Copy link

drzraf replied Jan 4, 2019

@carlhancock
Quoting the stance: "We are also considering opening up that repo to the public down the road." I wonder as we enter 2019 : are you still actually considering it?

Records of the use-cases are:

  • comment, issues and pull-requests as simple as with normal free and opensource GPL software
  • use publicly-hosted patches for our installations when upstream merge is not an option
  • plugin installation and update (be it mass-managed or not), as simple as composer update

(These are some of the reason why one would choose a free-software in the first place)

Please sign in to comment.
You can’t perform that action at this time.