Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclose the fact that numerous emoji are missing from this gem #23

Closed
jakelodwick opened this issue Nov 15, 2014 · 3 comments

Comments

@jakelodwick
Copy link

@jakelodwick jakelodwick commented Nov 15, 2014

"massage", "satellite", and other emoji don't work with this library.

The incompleteness, due to your reliance on the Phantom Open Emoji set, should be clearly spelled out at the top of the readme. This way, I may be the last person to waste an hour of his weekend digging through scripts and repos to find a really unexpected bug.

I like your gem otherwise, but it's called "emoji", implying that it's the Ruby library for handling those characters. The facts that it only handles some of them, and that you already knew about this issue but didn't tell us is bad form and frankly rude to your users.

@jakelodwick

This comment has been minimized.

Copy link
Author

@jakelodwick jakelodwick commented Nov 15, 2014

Perhaps recommend this one instead?

https://github.com/github/gemoji

@steveklabnik

This comment has been minimized.

Copy link
Collaborator

@steveklabnik steveklabnik commented Nov 15, 2014

You are he reason people burn out on open source. Don't be such an ass.

Repository owner locked and limited conversation to collaborators Nov 15, 2014
@steveklabnik

This comment has been minimized.

Copy link
Collaborator

@steveklabnik steveklabnik commented Nov 15, 2014

Oh, and also, you can use whatever image set you want, and it will work for those images. We have to use Phantom by default because distributing Apple Color Emoji is a copyright violation, which gemoji is currently violating

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.